Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non_exhaustive to all error enums #1026

Merged
merged 1 commit into from Jun 1, 2022
Merged

Add non_exhaustive to all error enums #1026

merged 1 commit into from Jun 1, 2022

Commits on May 31, 2022

  1. Add non_exhaustive to all error enums 

    Adding an error variant to a public enum is an API breaking change, this
means making what could be small refactorings or improvements harder. If
we use `non_exhaustive` for error types then we mitigate this cost.
There is a tradeoff however, downstream users who explicitly match on
our public error types must include a wildcard pattern.
    @tcharding
    tcharding committed May 31, 2022
    Copy the full SHA
    99f565f View commit details
    Browse the repository at this point in the history