Match on specific integer values #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use `Ordering` to match precision values against 0. We can match against the explicit integer values, this saves devs wondering why we compare to zero, and makes it explicit that there are a discreet number of valid precision values.
20 tasks
TheBlueMatt
reviewed
May 26, 2022
| @@ -384,7 +384,8 @@ fn fmt_satoshi_in( | |||
| let opt_precision = options.precision.unwrap_or(0); | |||
| trailing_decimal_zeros = opt_precision.saturating_sub(norm_nb_decimals); | |||
| }, | |||
| Ordering::Equal => trailing_decimal_zeros = options.precision.unwrap_or(0), | |||
| 0 => trailing_decimal_zeros = options.precision.unwrap_or(0), | |||
| _ => unreachable!(), // precision() only returns the values above. | |||
There was a problem hiding this comment.
Hmmm, I'm not a huge fan of adding more panics when we don't need to - I can totally see us forgetting to update this code based on a change to Denomination.
There was a problem hiding this comment.
True. If all codepaths work fine with any value, listing each value is just asking for trouble in the future.
There was a problem hiding this comment.
Fair points, thanks for the review. I'm going to close this and scratch out the task from the checklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
Orderingto match precision values against 0. We canmatch against the explicit integer values, this saves devs wondering why
we compare to zero, and makes it explicit that there are a discreet
number of valid precision values.
Done as part of the edition 2018 checklist.