Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom #1007

Merged
merged 5 commits into from Jun 29, 2022
Merged

Implement TryFrom #1007

merged 5 commits into from Jun 29, 2022

Commits on Jun 28, 2022

  1. Implement TryFrom for WitnessVersion 

    We have a bunch of 'from' methods that are fallible; `TryFrom` became
available in Rust 1.34 so we can use it now we have bumped our MSRV.

Implement the various `WitnessVersion` from methods using `TryFrom` and
deprecate the originals.
    @tcharding
    tcharding committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    632a5db View commit details
    Browse the repository at this point in the history

  2. Implement TryFrom<TaprootBuilder> for TapTree 

    TryFrom` became available in Rust 1.34 so we can use it now we have
bumped our MSRV.

Implement `TryFrom<TaprootBuilder>` for `TapTree` and deprecate the
`from_builder` method.
    @tcharding
    tcharding committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    5c49fe7 View commit details
    Browse the repository at this point in the history

  3. Implement TryFrom<Key> for ProprietaryKey 

    TryFrom` became available in Rust 1.34 so we can use it now we have
bumped our MSRV.

Implement `TryFrom<Key>` for `ProprietaryKey` and deprecate the
`from_key` method.
    @tcharding
    tcharding committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6b7b440 View commit details
    Browse the repository at this point in the history

  4. Implement TryFrom sha256::Hash for TaprootMerkleBranch 

    TryFrom` became available in Rust 1.34 so we can use it now we have
bumped our MSRV.

Add a macro for implementing `TryFrom` for various lists of
`sha256::Hash` types. Use the macro to for vec, slice, and boxed slice.
    @tcharding
    tcharding committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    af16286 View commit details
    Browse the repository at this point in the history

  5. Rename SchnorrSighashType::from_u8 -> from_consensus_u8 

    The `u8` parameter in the `SchnorrSighashType` constructor is a
consensus valid `u8`. Re-name the constructor to make this explicit.

Deprecate `from_u8` as is typical.
    @tcharding
    tcharding committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    b29ff9b View commit details
    Browse the repository at this point in the history