Add semver check to CI #1005
Closed
Add semver check to CI #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have increased the MSRV, this requires a 'minor' version bump (since we are pre v1.0).
Add a CI job to check if we have correctly set the crate version based on Semantic Versioning rules. This job was copied from: libp2p/rust-libp2p#2647 And uses this tool: https://github.com/rust-lang/rust-semverver
|
Lol, internal compiler error 🙃 |
|
Damn, I guess I'll have to make this work locally ... another day. |
|
One year has passed since I started this and now the tool is deprecated :( |
The new kid on the block is |
|
Thanks man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I currently cannot get
cargo semverto run locally so I'm going to abuse CI to run it.Add a CI job to check if we have correctly set the crate version based on Semantic Versioning rules.
This job was copied from: libp2p/rust-libp2p#2647
And uses this tool: https://github.com/rust-lang/rust-semverver
Thanks to @thomaseizinger for bringing this to my attention.