-
Notifications
You must be signed in to change notification settings - Fork 621
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #757: Minimally-invasive separation of bitcoin keys from ECDSA …
…signature types 8a993e8 Properly deprecate util::ecdsa key re-exports (Dr Maxim Orlovsky) bcb8932 Re-org keys and ecdsa mods - pt.3 (Dr Maxim Orlovsky) d1c2213 Re-org keys and ecdsa mods - pt.2 (Dr Maxim Orlovsky) b917016 Re-org keys and ecdsa mods - pt.1 (Dr Maxim Orlovsky) 2d9de78 Re-export all key types under `util::key`. Deprecate other exports. (Dr Maxim Orlovsky) Pull request description: This PR tries to do a minimally-invazive separation of signature- and key-related types, previously mixed in a single `util::ecdsa` module. Rationale: bitcoin key types are not specific for signature algorithm. See discussion at #588. This PR became possible after we moved on new `secp256k1` version exposing `XonlyPublicKey` type, since now all key types may co-exist in a single module under different names The PR goal is achieved through - Renaming ecdsa mod into private ec module such that the code is not copied and diff size is small; - Introducing dummy ecdsa mod back in the next commit and re-exporiting only signature types from internal `ec` mod in it; - Re-exporting all key types under `key` module, removing previous depreciation message for bitcoin keys. ACKs for top commit: apoelstra: ACK 8a993e8 sanket1729: utACK 8a993e8 Tree-SHA512: 9f71edaa2cf4cdab4b239cb1d57576e2ba0fc3c2ec0ea19ae232005967b9400da6ded992b33d10b190ca617a66dca9b99be430bc5058a064f0be1489723c4a3a
- Loading branch information
Showing
10 changed files
with
614 additions
and
609 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.