Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #924: Improvements to taproot script iterator
3c59897 Removed IntoIterator for TapTree implementation (Dr Maxim Orlovsky) 7a5482d Rename LeafInfo into ScriptLeaf (Dr Maxim Orlovsky) 2b8d965 Rename TapTree::iter into TapTree::script_leaves (Dr Maxim Orlovsky) 6f871ba Add convenience LeafInfo::depth method (Dr Maxim Orlovsky) 3c502ff Making all LeafInfo fields private (Dr Maxim Orlovsky) d655ff3 Make TapTreeIterator use LeafInfo (Dr Maxim Orlovsky) 79345fc LeafInfo field accessor methods (Dr Maxim Orlovsky) 5958466 Make LeafInfo::leaf_hash public and change its name and return type (Dr Maxim Orlovsky) c83893d Make taproot LeafInfo public (Dr Maxim Orlovsky) Pull request description: This PR makes existing taproot script iterator to iterate `LeafScript` values instead of constructed `(u8, &Script)`. First, this is more idiomatic (iterator should not construct value but iterate through real internal representation); second information about merkle path of the scripts is required for me downstream to implement OP_RETURN taproot commitments. The PR also removes unnecessary iterator type, replacing it with a slice iterator type from the core rust library. I am asking to include this PR into RC fix scope, since it is required downstream. ACKs for top commit: sanket1729: ACK 3c59897. Reviewed the range-diff with the post that I previously ACKed Tree-SHA512: 99e341443987204a8aba20869c750bd80a725f3d49d1b5731d554dff7377181b02a4517f8b390101afb2957135dbb255c6e360f90cadd6ee07b17eb14fd30af5
- Loading branch information
Showing
3 changed files
with
60 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters