Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #939: fix: reject message (de)serialization
548725c test: reject message (de)serialization (0xb10c) fc572ab fix: use var_str in 'reject' msgs (0xb10c) Pull request description: [BIP-61 defines `response-to-msg`][bip61] (`Reject::message` in rust-bitcoin; the message that triggered the reject) to be a `var_str`. However, by using the `CommandString` it was (de)serialized as 12 byte string. A test is added that de- and serializes two reject messages received from an older Bitcoin Core peer. Reject message sending has been removed from Bitcoin Core, I'm still receiving them from older peers from time to time. [bip61]: https://github.com/bitcoin/bips/blob/master/bip-0061.mediawiki#common-payload gh-ref: #323 ACKs for top commit: apoelstra: ACK 548725c Tree-SHA512: e5cbf215a471f113b4dd7f7fada162686fc6e8c7b1e2e9e641667208a36d3db610e57e8b549756ffe597656fee5444fe95466f1b88f45366595766f7c4640eea
- Loading branch information
Showing
2 changed files
with
38 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters