Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #2337: Add check to max difficulty transition threshold
fd6fedc Improve API for max target threshold calculation (Tobin C. Harding) 6e47d57 Rename difficulty transition threshold functions (Tobin C. Harding) 4121c9a Rename Params::pow_limit to max_attainable_target (Tobin C. Harding) f0f6d3f Take Params instead of Network in difficulty function (Tobin C. Harding) 104dee9 Debug assert that target != zero in difficulty calc (Tobin C. Harding) c1ba496 Document current behaviour of difficulty_float (Tobin C. Harding) 3d01146 Allow needless-borrows-for-generic-args (Tobin C. Harding) 2a6821b Use link to CompactTarget in rustdoc (Tobin C. Harding) Pull request description: When computing the maximum difficulty transition threshold we forgot to check that the returned `Target` is not bigger than the maximum. This value is network specific so keep the original logic but with `_unchecked` on the function name. This was noted in the discussion on #2161 ACKs for top commit: apoelstra: ACK fd6fedc sanket1729: ACK fd6fedc Tree-SHA512: 520ee2a07edb251c84b5ce8b48ed6e5a5c1945126dc7bcdb5570e97101ec4a3dc63fa7992725194869e22b21ee4f5955579d5e2499fcb48167637fd1fb3ae74d
- Loading branch information
Showing
8 changed files
with
85 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters