Disable Serde's default-features

With this patch, 'use-serde' will no longer compile serde/std. Those who wish to compile Serde with `std` should explicitely enable `std`.
rust-bitcoin · Apr 7, 2022 · 29677df · 29677df
1 parent cb4d34f
commit 29677df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Cargo.toml b/Cargo.toml
@@ -41,7 +41,7 @@ core2 = { version = "0.3.0", optional = true, default-features = false }
 
 base64-compat = { version = "1.0.0", optional = true }
 bitcoinconsensus = { version = "0.19.0-3", optional = true }
-serde = { version = "1", features = [ "derive" ], optional = true }
+serde = { version = "1", default-features = false, features = [ "derive" ], optional = true }
 hashbrown = { version = "0.8", optional = true }
 
 [dev-dependencies]

diff --git a/contrib/test.sh b/contrib/test.sh
@@ -94,6 +94,8 @@ then
     cargo new dep_test
     cd dep_test
     echo 'bitcoin = { path = "..", features = ["use-serde"] }' >> Cargo.toml
+    echo 'serde = { version = "1" }' >> Cargo.toml
+
 
     # Pin `cc` for Rust 1.29
     if [ -n "$PIN_VERSIONS" ]; then