Update the crate to edition 2018 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update to the edition 2018 * update dependencies to the latest * upgrade the MSRV to 1.36 (required by unicode-normalization 0.1) * make clippy happy Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
@stevenroose PTAL |
|
I'v been doing a series of changes in other PRs that are awaiting review. I'll look at this afterwards and see if I can incorporate some of the things. But I definitely don't want to bump the MSRV above the one of rust-bitcoin, which currently is 1.29. |
|
Why you don't want to bump the MSRV? |
|
Well that's something up for rust-bitcoin to decide, feel free to join our IRC channel #rust-bitcoin on Freenode. Especially in an ecosystem like Bitcoin it's not trivial for companies to publicly disclose the Rust version they are using. |
|
Relevant issue: rust-bitcoin/rust-bitcoin#510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro koushiro.cqx@gmail.com