Add benchmarks #97
Merged
Add benchmarks #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
04-03-bench
branch
5 times, most recently
from
a355a68
to
7dce69c
Compare
|
Needs rebase after #88. |
apoelstra
reviewed
Apr 3, 2023
README.md
Outdated
| ## Benchmarks | ||
|
|
||
| We use a custom Rust compiler configuration conditional to guard the bench mark code. To run the | ||
| bench marks use: `RUSTFLAGS='--cfg=bench' cargo +nightly bench`. |
There was a problem hiding this comment.
In 692a12c:
I think "benchmark" should be one word (it's split up in two locations).
|
ACK 7dce69c other than the merge conflicts. |
|
Rebased and fixed spelling of "benchmark" in the readme, no other changes. |
Add benchmarks for parsing and encoding bitcoin addresses. Also add two unit tests that parse the same address string used in the benchmarks. Specifically benchmark: - decoding an address - encoding an address with allocation - encoding an address without allocation Do so for both Bitcoin bech32 addresses and Bitcoin bech32m addresses.
We just added benchmarks to the crate, run them in CI when testing with the nightly toolchain.
apoelstra
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks for parsing and encoding bitcoin addresses. Also add two unit tests that parse the same address string used in the benchmarks.
Specifically benchmark:
Do so for both Bitcoin bech32 addresses and Bitcoin bech32m addresses.
Patch 1 is preparatory clean up to the readme.