Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: restore benchmarks #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

benchmarks: restore benchmarks #182

wants to merge 1 commit into from

Conversation

apoelstra
Copy link
Member

In #128 we dropped the benchmarks. They can be restored with only minor tweaks, so do so.

@apoelstra
benchmarks: restore benchmarks
82a577d 
In rust-bitcoin#128 we dropped the benchmarks. They can be restore with only minor
tweaks, so do so.
@apoelstra
Copy link
Member Author

CI failure is just because nightly rustc has introduced a new Freeze trait which appears in the check-API check. There is a commit to fix this in #180 which I won't copy into here to avoid rebase trouble.

tcharding
tcharding approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 82a577d

@apoelstra
Copy link
Member Author

cc @clarkmoody this is a quick/easy PR. Can you do a quick review?

Alternately, would you be okay with my merging things here with only ACKs from @tcharding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apoelstra @tcharding