Standard derives for error types #30
Conversation
|
I think this is ready for review / rebase and another run on Travis. |
|
No need of rebase, it's already on top of master and uses newly released version. Closed & opened to re-run Travis |
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "bitcoin-bech32" | |||
| version = "0.11.0" | |||
| version = "0.11.1" | |||
There was a problem hiding this comment.
needs a version bump after the bech32m release
Cargo.toml
Outdated
| @@ -14,4 +14,4 @@ license = "MIT" | |||
| strict = [] | |||
|
|
|||
| [dependencies] | |||
| bech32 = "0.7.1" | |||
| bech32 = "0.7.3" | |||
There was a problem hiding this comment.
Needs a bump to at least 0.8.0, maybe we also need a new release to add some derives there? Or maybe that was already included in 0.8.0?
There was a problem hiding this comment.
New derives went in before 0.8.0
There was a problem hiding this comment.
Still, having 0.8 will be better, or not?
There was a problem hiding this comment.
That's right. We depend on 0.8.0 for the Bech32m support from #31 .
dr-orlovsky
force-pushed
the
fix/error-derive
branch
from
116ef60
to
5e9fdb7
Compare
|
@sgeisler done |
|
can we have a release also pls? |
0.12.1 has been released on crates.io |
Based on rust-bitcoin/rust-bech32#49, will be ready for merge once new version of
rust-bech32will be published