Depend on bitcoincore-rpc v0.19.0
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe you're correct that if we need these features, we need to drop the range dependency. |
8 tasks
tcharding
force-pushed
the
05-01-upgrade-bitcoincore-rpc
branch
2 times, most recently
from
dd32842
to
dfad9c9
Compare
tcharding
changed the title
bitcoincore-rpc v0.19.0
The latest `bitcoincore-rpc` is not compatible with earlier versions so we can no longer use a range dependency. Upgrade to latest version of `bitcoincore-rpc` and remove the range dependency from crate manifest. In preparation for release, add a changelog entry and bump the version.
tcharding
force-pushed
the
05-01-upgrade-bitcoincore-rpc
branch
from
dfad9c9
to
9279882
Compare
|
Is it ok to have the version bump in the same PR/patch as the FTR there are no other commits since |
|
ACK 9279882 it's ok for me to have the version bump in the same PR/patch and to link the PR in the changelog going to merge/tag/publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest
bitcoincore-rpcis not compatible with earlier versions so we can no longer use a range dependency.Upgrade to latest version of
bitcoincore-rpcand remove the range dependency from crate manifest.In preparation for release, add a changelog entry and bump the version.