Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test inlining split_at_position #1740

Merged
merged 5 commits into from May 5, 2024
Merged

test inlining split_at_position #1740

merged 5 commits into from May 5, 2024

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Apr 22, 2024

No description provided.

@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8831835318

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 62.316%

Totals Coverage Status
Change from base Build 8831810839: -0.01%
Covered Lines: 1824
Relevant Lines: 2927

💛 - Coveralls

Copy link

codspeed-hq bot commented Apr 25, 2024

CodSpeed Performance Report

Merging #1740 will improve performances by 24.84%

Comparing inline-split (fe813ab) with main (5773e90)

Summary

⚡ 3 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark main inline-split Change
recognize float str 1.3 µs 1.1 µs +24.84%
recognize float str streaming 2.4 µs 2.1 µs +16.88%
number 287.2 ns 259.4 ns +10.71%

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.05%. Comparing base (5773e90) to head (fe813ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   62.25%   62.05%   -0.21%     
==========================================
  Files          24       24              
  Lines        2917     2912       -5     
==========================================
- Hits         1816     1807       -9     
- Misses       1101     1105       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Geal Geal merged commit cdd8baf into main May 5, 2024
31 of 32 checks passed
@Geal Geal deleted the inline-split branch May 5, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants