Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing commas in error_node_position and in error_position macros #1711

Merged
merged 2 commits into from May 5, 2024

Conversation

GuillaumeGomez
Copy link
Contributor

It's quite nice when having arguments on different lines to have each line end with a comma.

Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #1711 will improve performances by 10.71%

Comparing GuillaumeGomez:trailing-comma (7b47f77) with main (996efb8)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main GuillaumeGomez:trailing-comma Change
number 287.2 ns 259.4 ns +10.71%

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.43%. Comparing base (996efb8) to head (7b47f77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   61.47%   61.43%   -0.04%     
==========================================
  Files          24       24              
  Lines        2951     2951              
==========================================
- Hits         1814     1813       -1     
- Misses       1137     1138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Geal Geal merged commit 83cfb17 into rust-bakery:main May 5, 2024
18 of 19 checks passed
@GuillaumeGomez GuillaumeGomez deleted the trailing-comma branch May 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants