New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nit] Replace hard-coded bit count with constant. #1684

Closed

ttsugriy wants to merge 1 commit into rust-bakery:main from ttsugriy:bits-const

Contributor

ttsugriy commented Aug 14, 2023

This makes it clear what 8 stands for.


          [nit] Replace hard-coded bit count with constant.

9e625e4

This makes it clear what `8` stands for.

ttsugriy requested a review from Geal as a code owner

August 14, 2023 03:50

epage mentioned this pull request

refactor(bin): Make it clear what 8 stands for winnow-rs/winnow#309

Merged

Collaborator

Geal commented Oct 21, 2023

I'm not sure it makes things easier to read. If you work with bits, you know why 8 is there

Geal closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment