Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move usage towards AsChar method instead of functions under the character module #1597

Merged
merged 5 commits into from May 5, 2024

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Dec 30, 2022

This removes duplication and opens the way for changing complete vs
streaming parsers.

The problem is we still have something in `number` and `bits`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3807373087

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 60.825%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/traits.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
src/character/mod.rs 10 0%
Totals Coverage Status
Change from base Build 3796683738: -0.8%
Covered Lines: 1489
Relevant Lines: 2448

💛 - Coveralls

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 61.43%. Comparing base (cea6595) to head (6303c74).
Report is 1 commits behind head on main.

Files Patch % Lines
src/traits.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   62.14%   61.43%   -0.72%     
==========================================
  Files          24       24              
  Lines        2922     2938      +16     
==========================================
- Hits         1816     1805      -11     
- Misses       1106     1133      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #1597 will not alter performance

Comparing epage-aschar (6303c74) with main (cea6595)

Summary

✅ 24 untouched benchmarks

@Geal Geal merged commit d356bbe into main May 5, 2024
30 of 32 checks passed
@Geal Geal deleted the epage-aschar branch May 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants