[issues-1567] Add varint parsing #1568
Conversation
|
Wouldn't this be better implemented as a separate crate, much like https://crates.io/crates/nom-leb128? nom itself really only provides the most fundamental parsers and combinators. |
This make sense but i think varint is one of the fundamental parser. |
|
I think for this to go into nom proper, there would have to be parsers for every integer type at the very least; though I wouldn't put too much effort into it until @Geal confirms it'd be accepted. |
ikrivosheev
force-pushed
the
feature/issues-1567_varint
branch
from
1be03a8
to
4b2feb7
Compare
| loop { | ||
| let (i, byte) = le_u8(remainder)?; | ||
| result += (<R as From<u8>>::from(byte & 0x7F)) << ofs; | ||
| if byte < 0x80 { |
There was a problem hiding this comment.
I believe this should exit if enough bytes for the target data type have been collected. Otherwise the right shift or addition will overflow.
Add support:
varint_u64varint_u128This PR close: #1567.