Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of permutation_opt #1447

Closed
wants to merge 2 commits into from
Closed

implementation of permutation_opt #1447

wants to merge 2 commits into from

Conversation

Stargateur
Copy link
Contributor

Not perfect but open a door to Closes #1153

@coveralls
Copy link

coveralls commented Oct 25, 2021

Coverage Status

Coverage increased (+0.003%) to 81.054% when pulling aff0cba on Stargateur:impl_perm_opt into 02433c2 on Geal:main.

@Geal
Copy link
Collaborator

Geal commented Oct 25, 2021

I am still not sure if I want permutation_opt included in nom. I wrote one for matroska and that kind of combinator is very error prone

@Stargateur
Copy link
Contributor Author

This one https://github.com/rust-av/matroska/blob/95a75e389cb7cfa70b847ee09560b0fdeffac0f4/src/permutation.rs ?

There is some difference with my this simple one, seem, matroska one allow mix of optional parser, where this one force all optional or nothing.

I agree we could have this as an external crate as a follow up of #1439, I try to make a crate https://crates.io/crates/nom_permutation, first time for me so probably a lot of mistake.

In parallel, I work on a expand to n! as talk #1448, I believe now it's a external crate the size problem matter less.

@Stargateur Stargateur closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nom::branch::permutation does not support optional sub parsers
3 participants