Moving to MSRV 1.36.0 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
======================================
Coverage 63.9% 63.9%
======================================
Files 26 26
Lines 3347 3347
======================================
Hits 2138 2138
Misses 1209 1209 Continue to review full report at Codecov.
|
dr-orlovsky
force-pushed
the
develop
branch
3 times, most recently
from
fd7c783
to
060a459
Compare
|
Very strange thing, I didn't merge this PR. Seems like I did that by occasion locally from command line :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to use crates in rust-bitcoin projects, which will require rustc 1.36 from the next major release (rust-bitcoin/rust-bitcoin#510 (comment))
NB: MSRV will change only when
stringly_conversionsandserde_str_helpersare not used. With them, MSRV will remain 1.41.1. This difference is already reflected in tests and README