Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SQLITE_TEMP_STORE=3 on android. #937

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Apr 14, 2021

helps sqlite figure out how to deal with temp files on android.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #937 (10b730c) into master (ddf69f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files          48       48           
  Lines        5621     5621           
=======================================
  Hits         4369     4369           
  Misses       1252     1252           
Impacted Files Coverage Δ
libsqlite3-sys/build.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf69f7...10b730c. Read the comment docs.

@gwenn
Copy link
Collaborator

gwenn commented Apr 14, 2021

Not related to this PR but Docs check fails ! Should we specify the package: cargo rustdoc -p rusqlite --features '...' -- -D warnings ?
=> nightly related ]07e0e2ec2 2021-03-24, 132b4e5d1 2021-04-13]

@thomcc
Copy link
Member

thomcc commented Apr 14, 2021

Seems to be rust-lang/rust#84162. Given that it has P-critical, I think it will get sorted.

@gwenn
Copy link
Collaborator

gwenn commented Apr 14, 2021

Seems to be rust-lang/rust#84162. Given that it has P-critical, I think it will get sorted.

@thomcc Thanks for the investigation.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Apr 15, 2021

so anything left to do other than wait?

@gwenn gwenn merged commit 3519aef into rusqlite:master Apr 16, 2021
@dvc94ch
Copy link
Contributor Author

dvc94ch commented Apr 19, 2021

A release would be nice so that we can finally use rusqlite proper. We've been using our own fork because of this for 6mo, glad to see it gone soon.

@gwenn
Copy link
Collaborator

gwenn commented Apr 19, 2021

Ok, I will try to release libsqlite3-sys 0.22.1 and rusqlite 0.25.1 this week.

@gwenn
Copy link
Collaborator

gwenn commented Apr 19, 2021

Done.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Apr 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants