Fix google cloud storage with rustls + http2 #1985
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove host http header when using rustls in order for storage.googleapis.com to function with rustls
Hi!
We ran into a error using Rusoto with rustls enabled (quickwit-oss/quickwit#1584). It turns out Google rejects the http2 payload if it contains a host header. This fix feels a little hacky given that google seems to be the only provider to act this way. I can close this PR and open an issue if you prefer :)
Sample code which errors on the current main branch:
outputs
Err(HttpDispatch(HttpDispatchError { message: "Error obtaining body: Error obtaining chunk: error reading a body from connection: stream error received: unspecific protocol error detected" }))
with this branch:
Ok(ListBucketsOutput { buckets: Some([Bucket { creation_date: Some("2022-06-05T18:03:45.929Z"), name: Some("qw-region") }]), owner: None })
It's possible to use rusoto with rustls and GCP using a http1 client (quickwit-oss/quickwit#1612)