Make MockRequestDispatcher::with_request_checker to owned request #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to write a test for this if @benesch gives the soft go-ahead. This is a minor-breaking change. It's very minor because it should be as trivial as using |
allada
changed the title
Currently MockRequestDispatcher::with_request_checker takes a Fn that passes a non-mutable reference to the checker function. This causes issues for users who wish to check a streamed payload's contents because it is immutable. By making it owned it will no longer be a problem.
allada
force-pushed
the
with_request_checker-owned
branch
from
4c23423
to
d357bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MockRequestDispatcher::with_request_checker takes a Fn
that passes a non-mutable reference to the checker function. This
causes issues for users who wish to check a streamed payload's
contents because it is immutable. By making it owned it will no
longer be a problem.
This change is