Use ring crypto for 10-20% CPU utlilization gain #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computing SigV4 signatures uses SHA2 for the derivation. The Sha2 crate does not have architeture optimizations. By using Ring, we now have them and also they are selected at runtime. This manifests in 10-20% reduction of CPU utlilization for production workloads. A lot of `rusoto` users already have transitive dependency on `ring` through `rustls`, so this removes one more dependency for them.
|
would love to see this merged as well |
|
So sorry, but I don't really want to rock the boat here since rusoto is in maintenance mode. Based on a quick read I think the new official AWS SDK (https://github.com/awslabs/aws-sdk-rust) is using ring for signature computation. |
|
@benesch , yes, but the official SDK has a long way to be production ready, it is still in alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing SigV4 signatures uses SHA2 for the derivation. The Sha2 crate
does not have architeture optimizations. By using Ring, we now have them
and also they are selected at runtime. This manifests in 10-20% reduction
of CPU utlilization for production workloads.
A lot of
rusotousers already have transitive dependency onringthrough
rustls, so this removes one more dependency for them.