Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error reporting for invalid header value #1892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance error reporting for invalid header value #1892

wants to merge 2 commits into from

Conversation

ktff
Copy link

@ktff ktff commented Jan 17, 2021

Closes #1589

@ktff ktff mentioned this pull request Jan 17, 2021
Merged
phyber
phyber approved these changes Jan 19, 2021
View reviewed changes
Copy link

@phyber phyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The test failures appear to be unrelated rustc_version failings on nightly.

@ktff @benesch
Enhance error log
86acd1f 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff @benesch
Update changelog
35554d7 
Signed-off-by: ktf <krunotf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phyber phyber phyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accidental newline in AWS creds gives confusing "error parsing header value" message
2 participants
@ktff @phyber