Reduce the amount of llvm IR generated #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyber
reviewed
Jan 13, 2021
|
Thanks, @Marwes. The idea here seems good, but this is exactly the kind of large refactoring change that makes me nervous to merge given our current maintenance status (see #1902). The first two commits are definitely LGTM. If you wanted to split those out those can merge immediately. The other commits would require more time to review than I currently have, as they seem to change behavior at first glance ( |
|
Done, submitted the full changes as #1903. There shouldn't be any changes to the public API from my changes. Not sure what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rusoto generates a lot of code for each of its services which is noticable in its long compile time. These few commits follows the same ideas as in #1773 . Commonly generated code are extracted into helper functions that can be reused and wherever possible this are written in a manner to not have any type parameters so the code is only instantiated once.