deps: update to tokio v1.0

[benesch]

Just a draft for the moment. Waiting on:

• hyper-tls (Upgrade to Tokio 1.0 hyperium/hyper-tls#79)
• hyper-rustls (New release with tokio v1.0 rustls/hyper-rustls#138)
• reqwest (Update to tokio 1.0, bytes 1.0 seanmonstar/reqwest#1076)
• warp (Upgrade to Tokio 1.0 seanmonstar/warp#753) credential service mock rewritten to use hyper directly, rather than warp

[benesch]

Things are looking pretty good. The failures are because the integration_tests and skeptical crates are not part of the workspace and so don't get the tokio-native-tls patch that's specified in the root Cargo.toml. That'll all be fixed once we have actual releases of hyper-tls and hyper-rustls.

[fanatid]

Is this for rusoto:0.46.0?

[benesch]

Yep! The plan is to ship v0.46.0 as soon as this PR lands. I would expect in the next few days, but we're beholden to the hyper-tls and hyper-rustls maintainers.

[vitorenesduarte]

hyper-rustls 0.22 has landed: rustls/hyper-rustls@551d1d3

Here's the PR for hyper-tls: hyperium/hyper-tls#79

[benesch]

Whew, ok, all tests are green. I've updated the issue description to track exactly which crates we're waiting on releases for. In theory we could release without reqwest or warp, since those dependencies are only used in tests. But a release of hyper-tls is non-negotiable.

[extrawurst]

@benesch thanks for working on this! I am looking forward to this getting merged❤️

[benesch]

hyper-tls is out now. I'm going to wait a few days to see if tokio v1.0-compatible releases of reqwest + warp ship, for tidiness's sake. If either of those get wedged for some reason, I'll see about shipping with the Git-based dev-dependency.

[leepa]

We are waiting on warp for a test framework? reqwest is now updated and as warp is only used for the credential test (and therefore not in runtime code, and completely isolated) we should be good to merge and release this?

[benesch]

We are waiting on warp for a test framework? reqwest is now updated and as warp is only used for the credential test (and therefore not in runtime code, and completely isolated) we should be good to merge and release this?

The updated version of reqwest hasn't hit crates.io yet, unfortunately. Even though both reqwest and warp are used only as dev dependencies, I'm leery of merging a Git dependency to master, even as a dev dependency. It's too easy for our CI to break when those Git dependencies get updated upstream.

I imagine we'll get a new release of reqwest early this week, which I think is worth waiting for. Hopefully warp too, though it's easy enough to just replace our usage of warp with raw hyper if necessary.

[seanpianka]

You can pin a specific revision of a Git dependency, i.e. the git SHA of the commit with the updated version.

[benesch]

You can pin a specific revision of a Git dependency, i.e. the git SHA of the commit with the updated version.

In my experience that still has some pitfalls, sadly. Specific SHAs have a tendency to vanish from GitHub, e.g., when the branch backing a PR is force pushed, or when the PR is merged via a rebase-and-merge or squash-and-merge strategy (which rewrites the commits) and the original branch is deleted.

[extrawurst]

maybe we can make it a release candidate for the time being until there are actually named releases to point to for warp and request?

[benesch]

I know everyone is very excited to get a new release of Rusoto, but please just bear with me for another day, or two days at most! I'd like to avoid merging a Git dependency to master, which also precludes releasing an RC.

[extrawurst]

here we go, PR for the reqwest release open: seanmonstar/reqwest#1133

[benesch]

And reqwest v0.11 is out! Pending any unforeseen problems, I’ll get this shipped by tonight (EST).

[benesch]

Thanks for your patience, folks!