Skip to content

Fix a couple of java home checks bugs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2020
Merged

Fix a couple of java home checks bugs #110

merged 2 commits into from
Aug 29, 2020
+7 −10

Conversation

ZacSweers
Copy link
Contributor

  • Fix nullability in the env var, which was null at runtime
  • Don't double-pill the message when not failing on error

@ZacSweers
Fix nullability on env var

Verified

This commit was signed with the committer’s verified signature.
ZacSweers Zac Sweers
GPG key ID: 4D8159D6A1159B69
Verified
Learn about vigilant mode
8b5dc8d
@ZacSweers
Don't double-pill messages

Verified

This commit was signed with the committer’s verified signature.
ZacSweers Zac Sweers
GPG key ID: 4D8159D6A1159B69
Verified
Learn about vigilant mode
8938719
runningcode
runningcode approved these changes Aug 29, 2020
View reviewed changes
Copy link
Owner

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZacSweers

@runningcode runningcode merged commit 91b432c into runningcode:master Aug 29, 2020
@ZacSweers ZacSweers deleted the z/fixBugs branch August 29, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runningcode runningcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZacSweers @runningcode