feat: add experimental support for Cosign signing and verification #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
changed the title
|
LGTM, but need to update unit tests. There should also probably be an integration test for this new env pass-through, or Cosign itself |
ningziwen
force-pushed
the
cosign
branch
2 times, most recently
from
f41e67b
to
9bf23b8
Compare
pendo324
reviewed
Mar 20, 2023
ningziwen
force-pushed
the
cosign
branch
6 times, most recently
from
927162f
to
0219e51
Compare
pendo324
previously approved these changes
Apr 10, 2023
|
LGTM. I think we probably want to wait until the lima-and-qemu bundle is updated and pushed to main before merging. Longer-term, we should look into the environment variable issue / allowlist (or a way to get rid of the allowlist in general), since we have similar issues related to environment variables in e.g. compose files, but I'm ok with this solution to unblock adding Cosign support |
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
pendo324
approved these changes
Apr 11, 2023
ningziwen
changed the title
|
@pendo324 Changed the commit message to add experimental |
mharwani
pushed a commit
that referenced
this pull request
Apr 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.0...v0.6.0) (2023-04-20) ### Features * add experimental support for Cosign signing and verification ([#296](#296)) ([84c2634](84c2634)) ### Bug Fixes * always force stop when using Virtualization.framework ([#350](#350)) ([c521f1f](c521f1f)) * explicitly set permissions for socket_vmnet dependencies ([#363](#363)) ([0801b88](0801b88)) ### Build System or External Dependencies * add local-core Makefile target ([#351](#351)) ([f86c56f](f86c56f)) * **deps:** Bump github.com/docker/docker from 23.0.1+incompatible to 23.0.2+incompatible ([#320](#320)) ([ee3df9a](ee3df9a)) * **deps:** Bump github.com/docker/docker from 23.0.2+incompatible to 23.0.3+incompatible ([#343](#343)) ([6cfbb9f](6cfbb9f)) * **deps:** Bump github.com/lima-vm/lima from 0.15.0 to 0.15.1 ([#365](#365)) ([1d3ee98](1d3ee98)) * **deps:** Bump github.com/onsi/gomega from 1.27.5 to 1.27.6 ([#331](#331)) ([fe388a3](fe388a3)) * **deps:** Bump github.com/runfinch/common-tests from 0.6.4 to 0.6.5 ([#357](#357)) ([dc84864](dc84864)) * **deps:** Bump github.com/runfinch/common-tests version from v0.6.2 to v0.6.3 ([#328](#328)) ([1c44b3e](1c44b3e)) * **deps:** Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 ([#341](#341)) ([6a77f72](6a77f72)) * **deps:** Bump golang.org/x/crypto from 0.7.0 to 0.8.0 ([#349](#349)) ([82b27c9](82b27c9)) * **deps:** Bump golang.org/x/tools from 0.7.0 to 0.8.0 ([#348](#348)) ([aaca2c9](aaca2c9)) * **deps:** Bump k8s.io/apimachinery from 0.26.3 to 0.27.1 ([#366](#366)) ([b93d3a8](b93d3a8)) * **deps:** Bump lima version ([#354](#354)) ([c721ee6](c721ee6)) * **deps:** Bump lima version ([#362](#362)) ([5e03a4d](5e03a4d)) * **deps:** Bump lima version ([#368](#368)) ([8e4dfe4](8e4dfe4)) * **deps:** Bump submodules ([#340](#340)) ([daed9e2](daed9e2)) * **deps:** Bump submodules ([#371](#371)) ([19fc0c5](19fc0c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#295
Description of changes:
Add COSIGN_PASSWORD env pass-through to allow users use Cosign.
The feature should be experimental as it is experimental in Nerdctl. As Finch points to Nerdctl documentation today, users could see Cosign feature is experimental in Nerdctl documentation so will not mention experimental in Finch explicitly.
Testing done:
The tests only covers signing by push and verification by pull and run with the keys as MVP. The tests won't pass until the changed is integrated to Finch. Tested locally that it can work with this change in Nerdctl.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.