New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-2136: Fix step and node step plugin translation #8802
Open
leandromqrs
wants to merge
3
commits into
rundeck:main
Choose a base branch
from
leandromqrs:fix-plugin-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdevans
changed the title
Fix step and node step plugin translation
RUN-2136: Fix step and node step plugin translation
Jan 9, 2024
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
January 18, 2024 00:27
3a9cf1d
to
228c765
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
2 times, most recently
from
January 18, 2024 23:37
d9d841f
to
9bc06ec
Compare
ltamaster
force-pushed
the
fix-plugin-translation
branch
from
January 19, 2024 14:27
9bc06ec
to
d9d841f
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
4 times, most recently
from
February 2, 2024 21:23
40e4ef4
to
7d88005
Compare
I can't wait for it to be merged so I can contribute with my translations. |
leandromqrs
force-pushed
the
fix-plugin-translation
branch
4 times, most recently
from
February 9, 2024 20:52
a2cb6b9
to
f7563d1
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
3 times, most recently
from
February 20, 2024 19:57
3218223
to
28841d2
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
3 times, most recently
from
February 27, 2024 12:31
cf9201e
to
630a51d
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
2 times, most recently
from
March 7, 2024 18:55
c40784a
to
80e98c9
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
March 18, 2024 20:29
80e98c9
to
c757b13
Compare
leandromqrs
force-pushed
the
fix-plugin-translation
branch
from
March 21, 2024 18:16
c757b13
to
fe00729
Compare
@ltamaster sorry for the question, but, why it is not merged yet ? It's a very simple fix 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Bug fix when try to translate the step and node step plugins to another language.
Describe the solution you've implemented
When the messagePrefix is null, it puts the value of the property as
nullproperty.something.title
. After the fix, with the verification if is null, it puts with the correct valueproperty.something.title
Describe alternatives you've considered
Additional context
Additional images to compare the before and after...
Before
After
Before
After