Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with plugin select value with multiOption #5302

Merged
merged 3 commits into from Sep 27, 2019
Merged

Conversation

sjrd218
Copy link
Contributor

@sjrd218 sjrd218 commented Sep 26, 2019

Fixes #4109

Java plugins with a property that came from @SelectValues with multOption=true did not send their values to the server correctly. The server wasn't handling the value type correctly. That is now fixed too.

…ith the g:checkbox tag that

causes improper parameters to be sent to the form.
@sjrd218 sjrd218 added the v3.1.2 label Sep 26, 2019
@ProTip ProTip added this to the 3.1.2 milestone Sep 26, 2019
Copy link
Member

@gschueler gschueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is an example of how the old code didn't work?

@gschueler gschueler merged commit d7ec7b0 into master Sep 27, 2019
@gschueler gschueler deleted the issue/4109 branch September 27, 2019 18:22
@sjrd218 sjrd218 added the backport-to-3.0 (bot: creates backport pr for 3.0) label Oct 10, 2019
sjrd218 added a commit that referenced this pull request Oct 21, 2019
Fix issue with plugin select value with multiOption (bp #5302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-3.0 (bot: creates backport pr for 3.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rundeck Plugin Options type prevents saving of node step
4 participants