client-api: Add support for authenticated media endpoints #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kladki
reviewed
May 17, 2024
Kladki
reviewed
Jun 4, 2024
Comment on lines
6
to
8
| //! `/unstable/org.matrix.msc3916/` ([spec]) | ||
| //! | ||
| //! [spec]: https://github.com/matrix-org/matrix-spec-proposals/pull/3916 |
There was a problem hiding this comment.
Shouldn't we instead do the following on all these modules, like we do with (almost) all other unstable modules?
Suggested change
| //! `/unstable/org.matrix.msc3916/` ([spec]) | |
| //! | |
| //! [spec]: https://github.com/matrix-org/matrix-spec-proposals/pull/3916 | |
| //! `MSC3916` ([MSC]) | |
| //! | |
| //! [MSC]: https://github.com/matrix-org/matrix-spec-proposals/pull/3916 |
There was a problem hiding this comment.
Right. I think my inline code makes more sense compared to stable endpoints where we show the path segment.
There was a problem hiding this comment.
Meaning that here I would be for using my inline code and MSC for the link. And try to enforce that in the future.
Kladki
approved these changes
Jun 5, 2024
Kladki
reviewed
Jun 5, 2024
crates/ruma-client-api/src/authenticated_media/get_content_thumbnail.rs
Outdated
Show resolved
Hide resolved
According to MSC3916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MSC3916.
This does not add the federation endpoint because it seems that its format is not finalized. The MSC uses a single endpoint with a
multipart/mixedbody, to allow to include metadata with the media in the future. But there are suggestions to have separate endpoints for the metadata and the file content, or to include the metadata in the headers instead.