identifiers: Add signature-id compat mode for KeyId #1812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to replace split_id in ruma-signatures with KeyId::parse while having the exact same behavior.
Kladki
reviewed
May 30, 2024
Comment on lines
+32
to
+33
| #[cfg(feature = "compat-signature-id")] | ||
| let is_valid = is_valid || c == '+' || c = '/'; |
There was a problem hiding this comment.
Where in the spec does it mention these "compat" signature ids anyways?
There was a problem hiding this comment.
The point of the compat features is to conditionally improve compatibility with other Matrix software that fails to follow the spec properly.
|
Let's close this. Given the discussion in #1813, we should get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to replace
split_idin ruma-signatures withKeyId::parsewhile having the exact same behavior.