feat: Add heroes support for sliding sync room #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-sliding-sync-room-heros
branch
from
e092725
to
408d534
Compare
bnjbvr
changed the title
This patch is only based on https://github.com/matrix-org/sliding-sync/ pull/304 since the specification wasn't updated. I'm basically guessing what a request and a response _should_ look like: * `RoomSubscription` gains a new field: `include_heros`, * `SlidingSyncRoom` gains a new field: `heros`, * `SlidingSyncRoomHero` is a new type.
Hywan
force-pushed
the
feat-sliding-sync-room-heros
branch
from
408d534
to
50e1ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is only based on matrix-org/sliding-sync#304 since the specification wasn't updated. I'm basically guessing what a request and a response should look like:
RoomSubscriptiongains a new field:include_heroes,SlidingSyncRoomgains a new field:heroes,SlidingSyncRoomHerois a new type.