Skip to content

Commit

Permalink
xtask: Prevent Cargo from upgrading clap to 3.2
Browse files Browse the repository at this point in the history
  • Loading branch information
jplatte committed Jun 13, 2022
1 parent 20d0091 commit a47c8f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion xtask/Cargo.toml
Expand Up @@ -8,7 +8,7 @@ publish = false
default = ["isahc", "semver", "toml_edit"]

[dependencies]
clap = { version = "3.1.6", features = ["derive"] }
clap = { version = "~3.1", features = ["derive"] }

This comment has been minimized.

Copy link
@epage

epage Jun 15, 2022

This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.

isahc = { version = "1.7.0", features = ["json"], optional = true }
semver = { version = "1.0.6", features = ["serde"], optional = true }
serde = { version = "1.0.136", features = ["derive"] }
Expand Down
1 change: 1 addition & 0 deletions xtask/src/doc.rs
Expand Up @@ -3,6 +3,7 @@ use clap::Args;
use crate::{cmd, Result};

#[derive(Args)]
#[allow(deprecated)]
pub struct DocTask {
/// Open the browser when the docs are built.
#[clap(long)]
Expand Down
1 change: 1 addition & 0 deletions xtask/src/release.rs
Expand Up @@ -19,6 +19,7 @@ use crate::{cargo::Package, cmd, util::ask_yes_no, GithubConfig, Metadata, Resul
const GITHUB_API_RUMA: &str = "https://api.github.com/repos/ruma/ruma";

#[derive(Args)]
#[allow(deprecated)]
pub struct ReleaseArgs {
/// The crate to release
pub package: String,
Expand Down

0 comments on commit a47c8f0

Please sign in to comment.