Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an ErrorTransport (#1529) #1592

Merged
merged 3 commits into from Jan 21, 2019
Merged

Implement an ErrorTransport (#1529) #1592

merged 3 commits into from Jan 21, 2019

Commits on Jan 13, 2019

  1. Implement an ErrorTransport (#1529)

    When using AwsAuthV4 transport, it is possible that the user provides incorrect credentials.
    
    This means that the Guzzle client will get a 403 from AWS.
    
    By default Guzzle silently ignores all exceptions and stores them in `$response->setTransferInfo()`
    
    This feature allows a downstream client/library to handle them however.
    
    Currently, FOSElastica does nothing to process 403 or other errors that come back from ruflin/Elastica (transferInfo is never used).
    
    This causes a problem because 403 are silently ignored and the progress bar appears to be moving unhindered ;-)
    
    This PR is a pre-requisite for unit tests that will accompany this fix on FOSElastica
    # Conflicts:
    #	test/Elastica/Transport/NullTransportTest.php
    jandom committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    38ca2ce View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Update CHANGELOG.md

    jandom committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    45b69ae View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    jandom committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    7aa541e View commit details
    Browse the repository at this point in the history