Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: refactor requirements into server/client/dev, pin dependencies for server and dev #6767

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented May 14, 2024

Main commits

File structure

To avoid cluttering up the top-level directory, I've moved the requirements file into the requirements folder.

For dev and server, the requirements file with the .in suffix represent the input files to pip-compile; the .txt files are the requirements files generated by pip-compile. client does not have an .in file, because we are not pinning client dependencies.

Integration test failure

The integration test failure is due to this part of the dev Dockerfile in rucio/containers:

https://github.com/rucio/containers/blob/e75e7194cc9f404b46c977751c334b2b8f71b677/dev/Dockerfile#L75-L83

requirements.txt does not exist anymore, so this fails. I can make a PR to address this in rucio/containers, but the change would not be reflected until the next release, so I think the best way to handle this (once both PRs are approved) would be to:

  1. merge PR in rucio/containers
  2. manually update the rucio/dev image on Docker Hub
  3. merge this PR

@rdimaio rdimaio force-pushed the feature-6750-requirements branch 2 times, most recently from ce0cbda to 99c9dcb Compare May 24, 2024 08:20
@rdimaio
Copy link
Contributor Author

rdimaio commented May 24, 2024

Latest force-pushes:

@rdimaio rdimaio force-pushed the feature-6750-requirements branch from 99c9dcb to a17f16a Compare May 24, 2024 11:58
@rdimaio
Copy link
Contributor Author

rdimaio commented May 24, 2024

Rebased in latest forcepush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant