Clients: don't return success from uploader when registration fails #6670 #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimaio
previously approved these changes
May 10, 2024
jamesp-epcc
force-pushed
the
patch-6670-upload-client-declaration-failure
branch
from
34f07eb
to
7a81171
Compare
|
I've added a unit test that simulates the replica state update timing out and ensures that an exception is thrown as a result. |
rdimaio
approved these changes
May 14, 2024
bari12
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the upload client will not return success if updating the replica state or attaching to a dataset fails. Previously if the Rucio server timed out during one of these operations the upload was still flagged as a success and there was no way for the caller to detect the registration failure.