-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicas: For declaring bad replicas, use plugin for deteriming scope #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voetberg
force-pushed
the
patch-6363-softcode_scope_rule
branch
3 times, most recently
from
March 22, 2024 12:52
f78d56a
to
8341e96
Compare
cserf
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
rdimaio
reviewed
May 13, 2024
rdimaio
reviewed
May 13, 2024
rdimaio
reviewed
May 13, 2024
rdimaio
reviewed
May 13, 2024
rdimaio
reviewed
May 13, 2024
rdimaio
reviewed
May 13, 2024
The PR is currently comprised of 2 commits with the same commit message, might be best to squash them into one |
voetberg
force-pushed
the
patch-6363-softcode_scope_rule
branch
from
May 13, 2024 13:24
5e01a94
to
6448147
Compare
…gorithm based modification rucio#6363
voetberg
force-pushed
the
patch-6363-softcode_scope_rule
branch
from
May 13, 2024 13:48
6448147
to
6639f71
Compare
rdimaio
approved these changes
May 14, 2024
bari12
approved these changes
May 22, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the hard coded
Warning: Atlas Only
sections of replicas.__declare_bad_replicas and replicas.get_did_from_pfns to use a policy subclassed from policypackagealgorithms