Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicas: For declaring bad replicas, use plugin for deteriming scope #6444

Merged
merged 1 commit into from
May 22, 2024

Conversation

voetberg
Copy link
Contributor

@voetberg voetberg commented Jan 9, 2024

Replacing the hard coded Warning: Atlas Only sections of replicas.__declare_bad_replicas and replicas.get_did_from_pfns to use a policy subclassed from policypackagealgorithms

cserf
cserf previously approved these changes May 13, 2024
Copy link
Contributor

@cserf cserf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rdimaio
Copy link
Contributor

rdimaio commented May 13, 2024

The PR is currently comprised of 2 commits with the same commit message, might be best to squash them into one

@voetberg voetberg force-pushed the patch-6363-softcode_scope_rule branch from 6448147 to 6639f71 Compare May 13, 2024 13:48
@voetberg voetberg requested a review from rdimaio May 13, 2024 15:57
@bari12 bari12 merged commit cf9c2c7 into rucio:master May 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants