Ensure compatibility with --enable-frozen-string-literal
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://bugs.ruby-lang.org/issues/20205 In Ruby 3.4 string literals will be "chilled" by default. Meaning they are still mutable, but will pretend to be frozen. In most case it has no impact, just emit a few warnings there and there, but there is one thing it impacts is the `StringIO.new('')` pattern. `StringIO` checks if the given string is frozen, and if it is will act as a read only IO. This breaks rubyzip 2.x. This commit make the 2.x branch compatible with frozen string literals.
|
Thanks for doing this. I have to say my initial thought though was that I'd like to leave the 2.x branch (and Ruby 2.x) behind and frozen string literals would be a good way of doing this. However, it occurs to me that 3.x declares I'll merge this to the 2.4 branch, thanks. |
|
Thank you very much 🙇 |
|
Merged into the 2.4 branch now. Thanks again for your help! |
|
Released in 2.4.rc1 on rubygems now! |
|
It works, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/20205
In Ruby 3.4 string literals will be "chilled" by default. Meaning they are still mutable, but will pretend to be frozen.
In most case it has no impact, just emit a few warnings there and there, but there is one thing it impacts is the
StringIO.new('')pattern.StringIOchecks if the given string is frozen, and if it is will act as a read only IO.This breaks rubyzip 2.x.
This commit make the 2.x branch compatible with frozen string literals.
Note: I see all these issues are solved on master, but only released in an alpha, and I suppose ultimately will require a major version upgrade.
I think it would be good to provide a 2.x version compatible with Ruby 3.4, but your call.