Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop name cops #440

Merged
merged 9 commits into from Mar 14, 2020
Merged

Rubocop name cops #440

merged 9 commits into from Mar 14, 2020

Commits on Feb 17, 2020

  1. Fix Naming/BlockParameterName cop.

    @hainesr
    hainesr committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    846e704 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Fix Naming/MethodParameterName cop in the samples.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    fcadea6 View commit details
    Browse the repository at this point in the history

  2. Fix Naming/MethodParameterName cop in the tests.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    b09f05d View commit details
    Browse the repository at this point in the history

  3. Fix Naming/MethodParameterName cop in the library code.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    aa6ea05 View commit details
    Browse the repository at this point in the history

  4. Fix Naming/VariableName cop in the samples.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    7626423 View commit details
    Browse the repository at this point in the history

  5. Fix Naming/VariableName cop in the tests.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e6f414f View commit details
    Browse the repository at this point in the history

  6. Fix Naming/VariableName cop in the library code.

    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f9b161e View commit details
    Browse the repository at this point in the history

  7. Configure Naming/MemoizedInstanceVariableName in source. 

    Rather than turn it off for a whole file, it's better to mark these
exceptions in comments.
    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    c30d9df View commit details
    Browse the repository at this point in the history

  8. Fix Naming/AccessorMethodName in the tests. 

    This was kind of a misfire of this cop, but no bother to change.
    @hainesr
    hainesr committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    ce17c57 View commit details
    Browse the repository at this point in the history