Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop 0.79 #437

Merged
merged 56 commits into from Feb 16, 2020
Merged

Rubocop 0.79 #437

merged 56 commits into from Feb 16, 2020

Commits on Feb 15, 2020

  1. Update rubocop version and the config files. 

    Also rename .rubocop_rubyzip.yml to be consistent with Rubocop default
setup.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    c8bfd14 View commit details
    Browse the repository at this point in the history

  2. Add Rubocop tasks to the Rakefile.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    a3245ac View commit details
    Browse the repository at this point in the history

  3. Fix Gemspec/OrderedDependencies cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    aa40035 View commit details
    Browse the repository at this point in the history

  4. Fix Security/Open cop errors.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    73e405a View commit details
    Browse the repository at this point in the history

  5. Fix Style/OrAssignment cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    f1154c2 View commit details
    Browse the repository at this point in the history

  6. Fix Style/Semicolon cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    3a3ac6f View commit details
    Browse the repository at this point in the history

  7. Fix Style/BlockDelimiters cop errors.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    e7275da View commit details
    Browse the repository at this point in the history

  8. Fix Layout/SpaceAroundOperators cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    98c6969 View commit details
    Browse the repository at this point in the history

  9. Fix Lint/AmbiguousBlockAssociation cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    20743a5 View commit details
    Browse the repository at this point in the history

  10. Fix Lint/LiteralAsCondition cop. 

    This fixes Style/InfiniteLoop as a side-effect.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    b528cae View commit details
    Browse the repository at this point in the history

  11. Fix Lint/UnusedBlockArgument cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    cd065d0 View commit details
    Browse the repository at this point in the history

  12. Configure Lint/UselessComparison cop. 

    Allow this in entry_test.rb so we can test <=>.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    e361a47 View commit details
    Browse the repository at this point in the history

  13. Fix Lint/RescueException cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    23ba1af View commit details
    Browse the repository at this point in the history

  14. Fix Lint/UselessAccessModifier cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    0d49421 View commit details
    Browse the repository at this point in the history

  15. Configure Lint/SuppressedException cop. 

    In the tests we can say "anything goes", but in the main body of the
code we should at least comment if we're not handling an exception
fully.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    fff2c41 View commit details
    Browse the repository at this point in the history

  16. Fix Layout/EmptyLineAfterGuardClause cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    cfe4972 View commit details
    Browse the repository at this point in the history

  17. Configure Layout/HashAlignment cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    61c83b2 View commit details
    Browse the repository at this point in the history

  18. Fix Style/Encoding cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    68259ed View commit details
    Browse the repository at this point in the history

  19. Fix Style/ExpandPathArguments cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    70d036b View commit details
    Browse the repository at this point in the history

  20. Configure Style/ZeroLengthPredicate so it doesn't misfire.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    6544563 View commit details
    Browse the repository at this point in the history

  21. Fix Style/RescueStandardError cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    19aa7e8 View commit details
    Browse the repository at this point in the history

  22. Fix Style/RedundantReturn cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    5a1baf4 View commit details
    Browse the repository at this point in the history

  23. Fix Style/NonNilCheck cop. 

    Use the `refute_nil` method for most of these.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    b3c4c37 View commit details
    Browse the repository at this point in the history

  24. Fix Style/CommentedKeyword cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    b3f2413 View commit details
    Browse the repository at this point in the history

  25. Fix Style/IfInsideElse cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    468a80c View commit details
    Browse the repository at this point in the history

  26. Fix Style/Alias cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    3121ad0 View commit details
    Browse the repository at this point in the history

  27. Fix Naming/RescuedExceptionsVariableName cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    1b8f1a6 View commit details
    Browse the repository at this point in the history

  28. Fix Style/MixinUsage cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    bce8416 View commit details
    Browse the repository at this point in the history

  29. Fix Style/GuardClause cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    45f4c2d View commit details
    Browse the repository at this point in the history

  30. Fix Style/StringLiterals cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2e11a88 View commit details
    Browse the repository at this point in the history

  31. Configure Style/SymbolArray cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    cc0e372 View commit details
    Browse the repository at this point in the history

  32. Fix Style/TrailingCommaInArrayLiteral cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    4e1b679 View commit details
    Browse the repository at this point in the history

  33. Fix Style/UnpackFirst cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2dfe092 View commit details
    Browse the repository at this point in the history

  34. Configure Style/RegexpLiteral cop. 

    Allow inner slashes when using // for regex literals. Allow the
Guardfile to use a syntax that is more consistent with its own style.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    41f2359 View commit details
    Browse the repository at this point in the history

  35. Configure Style/MultilineBlockChain cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    5e32204 View commit details
    Browse the repository at this point in the history

  36. Fix Style/FloatDivision cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    172ab4b View commit details
    Browse the repository at this point in the history

  37. Fix Style/MultilineWhenThen cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    d42c66c View commit details
    Browse the repository at this point in the history

  38. Fix Style/EvalWithLocation cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2dc9b49 View commit details
    Browse the repository at this point in the history

  39. Fix Naming/HeredocDelimiterCase cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    835843d View commit details
    Browse the repository at this point in the history

  40. Configure Naming/MemoizedInstanceVariableName cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    7978abb View commit details
    Browse the repository at this point in the history

  41. Fix Style/Next cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2f99322 View commit details
    Browse the repository at this point in the history

  42. Fix Style/SignalException cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2cbdbf1 View commit details
    Browse the repository at this point in the history

  43. Fix Style/SpecialGlobalVars cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    bb3b447 View commit details
    Browse the repository at this point in the history

  44. Fix Style/SymbolProc cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    0df6cb3 View commit details
    Browse the repository at this point in the history

  45. Configure and fix Metrics/LineLength cop. 

    Set a workable line length for now, and fix a couple of particularly bad
examples.

Also, turn off for the tests.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    6cab592 View commit details
    Browse the repository at this point in the history

  46. Turn off Metrics/BlockLength for the tests.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    0e25e63 View commit details
    Browse the repository at this point in the history

  47. Configure Metrics/AbcSize and turn off for the tests.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    c97d560 View commit details
    Browse the repository at this point in the history

  48. Configure and fix Style/ClassCheck cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    5ce4e13 View commit details
    Browse the repository at this point in the history

  49. Configure Metrics/ClassLength and turn off for the tests.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    a9adfa2 View commit details
    Browse the repository at this point in the history

  50. Configure Metrics/MethodLength and turn off for the tests.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    a187ec0 View commit details
    Browse the repository at this point in the history

  51. Fix Layout/EmptyLinesAroundClassBody cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    4b8f740 View commit details
    Browse the repository at this point in the history

  52. Fix Style/NumericLiteralPrefix cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    fae95e3 View commit details
    Browse the repository at this point in the history

  53. Fix Style/TernaryParentheses cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    d07b36b View commit details
    Browse the repository at this point in the history

  54. Fix Style/TrailingCommaInHashLiteral cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    989a565 View commit details
    Browse the repository at this point in the history

  55. Fix Style/NumericLiterals cop.

    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    c31ab81 View commit details
    Browse the repository at this point in the history

  56. Set TargetRubyVersion to match that in the gemspec. 

    Currently 2.4 is the earliest supported ruby version.
    @hainesr
    hainesr committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    87a63e0 View commit details
    Browse the repository at this point in the history