Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the UniversalTime extra field #421

Merged
merged 6 commits into from Dec 27, 2019
Merged

Fixes for the UniversalTime extra field #421

merged 6 commits into from Dec 27, 2019

Commits on Dec 15, 2019

  1. UniversalTime: correctly set the flags. 

    When a timestamp is set/unset the flags should reflect this.
    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    b58b97f View commit details
    Browse the repository at this point in the history

  2. UniversalTime: correctly pack/unpack the timestamps. 

    From the documentation: "The time values are in standard Unix signed-long
format, indicating the number of seconds since 1 January 1970 00:00:00."

The three time values were being unpacked with 'VVV', which is unsigned
32-bit, but they should be unpacked with 'l<l<l<': signed-long little
endian.
    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    65cfd8a View commit details
    Browse the repository at this point in the history

  3. UniversalTime: better check for size on parse.

    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    a5e785c View commit details
    Browse the repository at this point in the history

  4. UniversalTime: correctly parse included timestamps. 

    From the documentation: "...times that are present will appear in the
order indicated, but any combination of times may be omitted. (Creation
time may be present without access time, for example.)"

This fixes the parsing so that the times are read into the correct
fields, according to the flags. Before they were simply assumed to be in
order and all present.
    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    9849500 View commit details
    Browse the repository at this point in the history

  5. UniversalTime: tests.

    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    d0b4d41 View commit details
    Browse the repository at this point in the history

  6. UniversalTime: more ruby-like (readable) code.

    @hainesr
    hainesr committed Dec 15, 2019
    Copy the full SHA
    ee028d2 View commit details
    Browse the repository at this point in the history