Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restore_times option when extracting, and test file options #413

Merged
merged 5 commits into from Oct 27, 2019
Merged

Fix restore_times option when extracting, and test file options #413

merged 5 commits into from Oct 27, 2019

Commits on Oct 19, 2019

  1. Correctly set/default options in the File class. 

    Fixes rubyzip#395. Set the options to false for now for consistency.
    @hainesr
    hainesr committed Oct 19, 2019
    Copy the full SHA
    2534575 View commit details
    Browse the repository at this point in the history

  2. Make the attr_accessors in File more readable. 

    Note what the default is and that a couple of them will change at some
point soon.
    @hainesr
    hainesr committed Oct 19, 2019
    Copy the full SHA
    3782935 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. Add functionality to restore file timestamps. 

    There has been an option in `Zip::File` (`:restore_times`) for a long
time, but it seems it has never worked. Firstly the actual timestamp of
an added file wasn't being saved, and secondly an extracted file wasn't
having its timestamp set correctly.

This commit fixes both of those issues, and adds tests to make sure.
    @hainesr
    hainesr committed Oct 20, 2019
    Copy the full SHA
    8c694d3 View commit details
    Browse the repository at this point in the history

  2. Add a convenience method for creating DOSTime instances. 

    DOSTime::from_time creates a DOSTime instance from a vanilla Time
instance.
    @hainesr
    hainesr committed Oct 20, 2019
    Copy the full SHA
    2bdd37d View commit details
    Browse the repository at this point in the history

  3. Add a test for restoring file permissions on extract.

    @hainesr
    hainesr committed Oct 20, 2019
    Copy the full SHA
    1a21f39 View commit details
    Browse the repository at this point in the history