Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Ruby #412

Closed
wants to merge 540 commits into from
Closed

Stable Ruby #412

wants to merge 540 commits into from

Conversation

GrimmDaddy
Copy link

  • Create temporary files in the system temporary directory instead of the directory of the zip file #411
  • Drop unused tmpdir requirement #411

jdleesmiller and others added 28 commits July 20, 2019 15:15
Fix #280 - `open_buffer` mangles the content of the buffer it is given.
As per https://guides.rubygems.org/specification-reference/#metadata,
add metadata to the gemspec file. This'll allow people to more easily
access the source code, raise issues and read the changelog. These
`bug_tracker_uri`, `changelog_uri`, `documentation_uri`, `wiki_uri` and
`source_code_uri` links will appear on the rubygems page at
https://rubygems.org/gems/rubyzip and be available via the rubygems API
after the next release.
Add project metadata to the gemspec
Adding uncompressed files to a zip archive can be overly complex, so
this convenience method makes it easier.
Zip::File.add_stored() to add uncompressed files.
Validate entry sizes when extracting
Rather than using the local folder.

Fixes #410
It's not used in the library code.
Clean up temp file usage and fix #410
@hainesr
Copy link
Member

hainesr commented Oct 5, 2019

This looks like a rogue PR to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet