Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.3 #393

Merged
merged 2 commits into from May 23, 2019
Merged

Bump version to 1.2.3 #393

merged 2 commits into from May 23, 2019

Conversation

jdleesmiller
Copy link
Member

@olleolleolle @aspiers @vipulnsward @bdewater @hainesr @d235j @taichi-ishitani @mihyaeru21 @tuzovakaoff @JackMc Thanks for your recent contributions to rubyzip 馃憦.

I'm helping @simonoff with maintenance on this library now.

I'm working toward this release mainly to fix any problems I caused with #376 in trying to fix CVE-2018-1000544 (#369). I've also reviewed and pulled in some other recent small fix PRs and done some housekeeping for CI, but I haven't attempted to merge anything larger or further down in the backlog for this release.

  1. Do you have any views on Allow tilde in zip entry names聽#391 ? That's the last piece needed for this release, and it has some security implications. It would be good to have someone other than me review it.

  2. I've updated the changelog this time and added my very short summaries of some of your PRs. Comments also welcome on this.

I can merge PRs but still can't release a new version, so that may still require help from Alex (or one of the other gem owners).

Going forward: I will try to stay on top of new security-related problems and obvious bugs. There is quite a bit in the backlog, of which I have only scratched the surface, so I'd be interested to get your thoughts on other priorities.

@coveralls
Copy link

coveralls commented Mar 22, 2019

Coverage Status

Coverage remained the same at 95.754% when pulling ada408d on v1-2-3 into 8ece5c9 on master.

@jdleesmiller jdleesmiller merged commit 6f0b219 into master May 23, 2019
@jdleesmiller jdleesmiller deleted the v1-2-3 branch May 23, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants