Prevent NoMethodError crash when missing data in extra field #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found by fuzzing rubyzip.
When creating an
ExtraField
from a binary string, in the#merge
method there is no check for thebinstr
length, resulting in eitherid
orlen
variables possibly being set to nil. I created a quick fix that raises aZip::Error
if either of these variables are nil to prevent an unhandledNoMethodError
when using them.Raw crash
Reproduce with this file (extra_field.rb:14) or this one (extra_field.rb:12)