Prevent TypeError in read_central_directory_entries and use Zip::Error #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found by fuzzing rubyzip.
In the
#read_central_directory_entries
method,@cdir_offset
can be nil resulting in the call toio.seek
raising an unhandledTypeError
exception. It appears@cdir_offset
is set in#read_e_o_c_d
or#read_64_e_o_c_d
, but I am not sure that it is considered a failure for it to be set to nil there, so in my fix I threw aZip::Error
exception just before trying to use the non-existent cdir_offset.Raw crash
Reproduce with this file