New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2018-1000544 and disable symlinks to avoid other security issues #376
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6e0d231
Fix CVE-2018-1000544 absolute path traversal
bdewater 8e78311
Fix CVE-2018-1000544 symlink path traversal
bdewater cf71583
Move jruby to allow failures matrix till crc uint 32 issues are resolved
vipulnsward 0586329
Trigger CI again
bdewater 9c468f3
Add jwilk's path traversal tests
jdleesmiller ffebfa3
Consolidate path traversal tests
jdleesmiller 3dd165b
Disable symlinks and check for path traversal
jdleesmiller 8a1de58
Expand from root rather than current working directory
jdleesmiller ffb374c
Bump version to 2.0.0
jdleesmiller cf35774
Bump version to 1.3.0
jdleesmiller fd81bd5
Bump version to 1.2.2
jdleesmiller File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module Zip | ||
| VERSION = '1.2.1' | ||
| VERSION = '2.0.0' | ||
| end | ||
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdleesmiller can you please revert this? Or at least release a patch version of 1.2 as well?
The thing is all the libraries we have in
Gemfile.lockeither explicitly declare< 2.0.0or~> 1.2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. That is a good point about version constraints.
My rationale was that dropping support for symlinks completely is a breaking change, and I'd be unhappy if semver minor or patch release broke my app.
If you have
~> 1.2, I guess 1.3.0 should do it. It's not very semantic, but it does seem like the pragmatic solution. Happy to try it out.